[Asterisk-code-review] taskprocessor: Add high water mark warnings (asterisk[master])

Jonathan Rose asteriskteam at digium.com
Thu Nov 5 15:39:49 CST 2015


Jonathan Rose has posted comments on this change.

Change subject: taskprocessor: Add high water mark warnings
......................................................................


Patch Set 2:

I went ahead and upped the required tasks in queue for a high water level warning to be issued to 100 per Mark's feedback. However, adding complexity to the feature in this review is rejected for now. We'll have a mailing list discussion for improvements, but this patch is intended to be very minimal and issue one time warnings when things are almost certainly in a weird state primarily for diagnostic purposes when we are looking at logs to hunt for stalled task processors. Later on, a way of returning to the safe state could be useful and so could configurable high/low water levels set per task processor, but that's not the focus here.

-- 
To view, visit https://gerrit.asterisk.org/1562
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1607c35d18c1d6a0575b3f0e3ff5d932fd6600c
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list