[Asterisk-code-review] StatsD: Add res statsd compatibility (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: StatsD: Add res_statsd compatibility
......................................................................


Patch Set 1: Code-Review-1

My main problem with this new function is that it's an exact copy-paste of the pre-existing ast_statsd_log_full function just with a different format string being used for ast_str_append.

Since the logic is exactly the same apart from that, I feel like both ast_statsd_log_full() and ast_statsd_log_string() should call into a common routine. This way the logic is not repeated.

@Josh: Everything you've pointed out as a problem in Tyler's new function also exists in ast_statsd_log_full(), FYI. Another reason why factoring the common logic to its own function would work well here.

-- 
To view, visit https://gerrit.asterisk.org/1561
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6bb53600943d27347d2bcae26c0bd5643567611
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tyler Cambron <tcambron at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No