[Asterisk-code-review] taskprocessor: Add high water mark warnings (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: taskprocessor: Add high water mark warnings
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/1562/2/main/taskprocessor.c
File main/taskprocessor.c:

Line 719: #define HIGH_WATER_LEVEL 40
> How much overhead would it take to create a new field to store high water l
Shouldn't be that much.


Line 741: 	if (previous_size >= HIGH_WATER_LEVEL && !tps->high_water_warned) {
> I suppose that Matt may be able to answer this better, but the current "war
Agreed. I think if the taskprocessor gets cleared out to a reasonable (rather subjective) level then next time we should output the warning again. Knowing that it is consistently getting high and then clearing out is good information to have itself.


-- 
To view, visit https://gerrit.asterisk.org/1562
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1607c35d18c1d6a0575b3f0e3ff5d932fd6600c
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes