[Asterisk-code-review] Add syslog logging to test runs. (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: Add syslog logging to test runs.
......................................................................


Patch Set 3:

> (1 comment)

I'd be careful with catching exceptions just to log them.

If we accidentally caught an exception, logged it, and then allowed runtests.py to continue to run, we may put it into a situation where it stops proceeding but also doesn't exit. This would then hang the CI builds.

We had a lot of problems with this in the past with specific tests.

Generally, exceptions thrown in runtests.py will get dumped to stderr, which most of our CI infrastructure will capture and log out to their own logs.

In other situations, I can see why having runtests.py blowing up would not get caught - however, that's a much rarer edge case than our current deployment scenarios.

Regardless, I'm not sure why having all unhandled exceptions get logged would be a -1 to adding syslog logging. That doesn't feel like it's part of this change set, unless I'm missing something.

-- 
To view, visit https://gerrit.asterisk.org/1560
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33d7fba756a83e9c4d3a7c2d51482c44b97bf67c
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No