[Asterisk-code-review] taskprocessor: Add high water mark warnings (asterisk[master])

Matt Jordan asteriskteam at digium.com
Tue Nov 3 16:35:55 CST 2015


Matt Jordan has posted comments on this change.

Change subject: taskprocessor: Add high water mark warnings
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1562/1/main/taskprocessor.c
File main/taskprocessor.c:

Line 719: #define HIGH_WATER_LEVEL 20
If we're likely to trip this on startup, then we need to change the level warning mark to something much higher.


Line 741: 	if (!tps->high_water_warned && previous_size >= HIGH_WATER_LEVEL) {
Change the ordering on this, as normal operation would have this be typically under the HIGH_WATER_LEVEL (which would mean one less evaluation):

if (previous_size >= HIGH_WATER_LEVEL && !tps->high_water_warned) {

}


-- 
To view, visit https://gerrit.asterisk.org/1562
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1607c35d18c1d6a0575b3f0e3ff5d932fd6600c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list