[Asterisk-code-review] StatsD: Send stuff to the StatsD server and test (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: StatsD: Send stuff to the StatsD server and test
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Minor comment.

https://gerrit.asterisk.org/#/c/1542/3/apps/app_statsd.c
File apps/app_statsd.c:

Line 228: 	numerical_value = strtod(args.value, NULL);
You should add a comment of why this is safe since you validate the value up above.


-- 
To view, visit https://gerrit.asterisk.org/1542
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I400db2f37c6ddf61515ff5a019646e36dcd0f922
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tyler Cambron <tcambron at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes