[Asterisk-code-review] res sorcery memory cache: Add CLI commands and AMI actions. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_sorcery_memory_cache: Add CLI commands and AMI actions.
......................................................................


Patch Set 1: Code-Review+1

I gave this a look and ran through the scenarios in my head of the various potential simultaneous scenarios (e.g. expiring an object over AMI while a stale update is running in the background). Worst thing I could find was potentially having an already stale object get refreshed twice instead of once, or an object you are attempting to expire immediately getting refreshed due to a scheduled stale update task.

In either case, I think the work and potential performance hits it would take to prevent these from happening is not worth it.

Looks good to me.

-- 
To view, visit https://gerrit.asterisk.org/543
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68e03cfd8c34b5e07f4b6ee4fd93a3f4a00a3d9e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No