[Asterisk-code-review] res sorcery meory cache: Add support for refreshing stale ob... (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_sorcery_meory_cache: Add support for refreshing stale objects.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/540/2/res/res_sorcery_memory_cache.c
File res/res_sorcery_memory_cache.c:

Line 606: 	task_data->sorcery = sorcery;
> Should probably hold a ref to the sorcery instance as well.
Initially I had done that. The problem is that the function where stale_update_task_data_alloc() is called from has a const sorcery pointer. This means I have to pass around const sorcery pointers, and I can't bump refcounts on const objects.

I could potentially perform casts to non-const if that would be a possible solution here.


-- 
To view, visit https://gerrit.asterisk.org/540
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bd7c049adf6939bfe2899f393c2bfbbf412d217
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes