[Asterisk-code-review] res pjsip session: Fix in-dialog authentication. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip_session: Fix in-dialog authentication.
......................................................................


Patch Set 1:

I think moving this to res_pjsip_session.c is a good call. The idea behind res_pjsip_outbound_auth.c was originally an optimistic goal of having all dialog-base authentication automatically be handled in one place. The problem is that in practice this doesn't work well for inv_session-based dialogs. I suspect that this would also be the case for evsub dialogs when we add support for outbound SUBSCRIBE dialogs. So I'm up for just taking the needed portions from here and moving them into res_pjsip_session and nuking pjsip_outbound_auth.c.

-- 
To view, visit https://gerrit.asterisk.org/535
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bdd7ddccc819b4ce4b091e826d1e26334601b0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No