[Asterisk-code-review] res pjsip session: Fix in-dialog authentication. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_session: Fix in-dialog authentication.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/535/1/res/res_pjsip/pjsip_outbound_auth.c
File res/res_pjsip/pjsip_outbound_auth.c:

Line 65: 	if (tsx->method.id != PJSIP_INVITE_METHOD) {
       : 		/* Not an INVITE that needs authentication */
       : 		return PJ_FALSE;
       : 	}
       : 
       : 	inv = pjsip_dlg_get_inv_session(dlg);
       : 	if (PJSIP_INV_STATE_CONFIRMED <= inv->state) {
       : 		/*
       : 		 * We cannot handle reINVITE authentication at this
       : 		 * time because the reINVITE transaction is still in
       : 		 * progress.  Authentication will get handled by the
       : 		 * session state change callback.
       : 		 */
       : 		ast_debug(1, "A reINVITE is being challenged.\n");
       : 		return PJ_FALSE;
       : 	}
       : 	ast_debug(1, "Initial INVITE is being challenged.\n");
The code previously had nothing special - ie: it was not INVITE session specific. What sort of impact does making it INVITE specific have for other stuff?

Why is this code not invoked on the scenarios you've explicitly put code in to handle? When is it invoked? Do we need additional documentation detailing that? Should it be invoked then?


-- 
To view, visit https://gerrit.asterisk.org/535
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bdd7ddccc819b4ce4b091e826d1e26334601b0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes