[Asterisk-code-review] res pjsip: Add AMI events for chan pjsip contact lifecycle c... (asterisk[13])

George Joseph asteriskteam at digium.com
Tue May 26 16:32:40 CDT 2015


George Joseph has posted comments on this change.

Change subject: res_pjsip: Add AMI events for chan_pjsip contact lifecycle changes
......................................................................


Patch Set 3:

> > (1 comment)
 > 
 > IIRC, it didn't like long ints.  Maybe that was with 'i' though. 
 > I'll test again.

Yeah, 'd' isn't a valid specifier and both 'i' and 'I' cause pack to ignore the variable.

You did caused me to notice that using "%ld" with an int64_t wasn't 32bit compatible so a patch is forthcoming.

-- 
To view, visit https://gerrit.asterisk.org/518
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id25aae5f7122facba183273efb3e8f36c20fb61e
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list