[Asterisk-code-review] res pjsip: Add AMI events for chan pjsip contact lifecycle c... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip: Add AMI events for chan_pjsip contact lifecycle changes
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/518/2/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 88: 			char rtt[32];
       : 			snprintf(rtt, 31, "%ld", status->rtt);
       : 			blob = ast_json_pack("{s: s, s: s, s: s, s: s, s: s}",
       : 				"contact_status", ast_sip_get_contact_status_label(status->status),
       : 				"aor", aor,
       : 				"uri", status->uri,
       : 				"roundtrip_usec", rtt,
I'm curious why the rtt variable is used here. Why not just use status->rtt directly by using 'd' in the JSON format string?


-- 
To view, visit https://gerrit.asterisk.org/518
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id25aae5f7122facba183273efb3e8f36c20fb61e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes