[Asterisk-code-review] res/res pjsip exten state: Fix confusing NOTICE message (asterisk[13])

Matt Jordan asteriskteam at digium.com
Fri May 22 12:20:47 CDT 2015


Matt Jordan has uploaded a new change for review.

  https://gerrit.asterisk.org/521

Change subject: res/res_pjsip_exten_state: Fix confusing NOTICE message
......................................................................

res/res_pjsip_exten_state: Fix confusing NOTICE message

When a SUBSCRIBE request is made to a dialplan hint that doesn't exist,
the current NOTICE message informing users of this swaps the context and
extension parameters. This can cause a bit of confusion.

Thanks to CptBurger in #asterisk for helping to point this out.

Change-Id: Ie584d1a58ae217385c87a450ca25b55ca0e36e43
---
M res/res_pjsip_exten_state.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/21/521/1

diff --git a/res/res_pjsip_exten_state.c b/res/res_pjsip_exten_state.c
index a05e191..3dc8c1a 100644
--- a/res/res_pjsip_exten_state.c
+++ b/res/res_pjsip_exten_state.c
@@ -354,7 +354,7 @@
 {
 	if (!ast_exists_extension(NULL, endpoint->context, resource, PRIORITY_HINT, NULL)) {
 		ast_log(LOG_NOTICE, "Extension state subscription failed: Extension %s does not exist in context '%s' or has no associated hint\n",
-			endpoint->context, resource);
+			resource, endpoint->context);
 		return 404;
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie584d1a58ae217385c87a450ca25b55ca0e36e43
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list