[Asterisk-code-review] Add local attended transfer tests with direct media, hold, a... (testsuite[master])

[John Bigelow]

Hello Samuel Galarneau, Ashley Sanders,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/483

to look at the new patch set (#4).

Change subject: Add local attended transfer tests with direct media, hold, and REFER/Replaces.
......................................................................

Add local attended transfer tests with direct media, hold, and REFER/Replaces.

This adds two pjsip tests for caller and callee initiated local attended
transfers with direct media, hold, and REFER/Replaces. Both tests use the
packet_sniffer.py module to check AMI UserEvents that it generates.

* packet_sniffer.py: This sniffs SIP packets to track calls. It generates an
AMI UserEvent when a remote bridge is setup on two call legs, when a remote
bridge is torn down on a call leg, and when a REFER, Notify sipfrag, and 491
Request Pending is found.
* lib/python/asterisk/pcap.py: Fix the finding of SIP packets and attribute
references.
* lib/python/asterisk/phones.py: When a pjsua operation (transfer/hold) is
performed and before any callbacks are called or state changes occur, there is
no way to know that an operation is in progress. This adds tracking of calls
with operations (transfer & hold) that are in progress. When an operation is in
progress for a call, this prevents the same operation from being performed on
the call. This also adds additional call & media state checking and updates
some of the exception handling.

ASTERISK-23644 #close
Reported by: Matt Jordan

Change-Id: Ibd1f9a3ea8bf6b80fe95efe3fcd880a55d5a7cae
---
M lib/python/asterisk/pcap.py
M lib/python/asterisk/phones.py
A tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_direct_media/configs/ast1/extensions.conf
A tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_direct_media/configs/ast1/pjsip.conf
A tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_direct_media/test-config.yaml
A tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/configs/ast1/extensions.conf
A tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/configs/ast1/pjsip.conf
A tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/test-config.yaml
A tests/channels/pjsip/transfers/attended_transfer/nominal/packet_sniffer.py
M tests/channels/pjsip/transfers/attended_transfer/nominal/tests.yaml
10 files changed, 1,208 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/83/483/4
-- 
To view, visit https://gerrit.asterisk.org/483
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd1f9a3ea8bf6b80fe95efe3fcd880a55d5a7cae
Gerrit-PatchSet: 4
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: John Bigelow <jbigelow at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: John Bigelow <jbigelow at digium.com>
Gerrit-Reviewer: Samuel Galarneau <sgalarneau at digium.com>