[Asterisk-code-review] channels/pjsip/subscriptions/mwi/mwi aggregate: Fix undefine... (testsuite[master])

Matt Jordan asteriskteam at digium.com
Fri May 22 10:38:06 CDT 2015


Matt Jordan has submitted this change and it was merged.

Change subject: channels/pjsip/subscriptions/mwi/mwi_aggregate: Fix undefined reference
......................................................................


channels/pjsip/subscriptions/mwi/mwi_aggregate: Fix undefined reference

This patch fixes an undefined reference to a presumed global variable,
'controller'. The variable is actually a member of PJMWICallback. This
prevents an exception from occurring when the test fails.

Change-Id: If536cc76052c0e68e4e5b97384bec2838295c35b
---
M tests/channels/pjsip/subscriptions/mwi/mwi_aggregate/mwi_check.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Matt Jordan: Looks good to me, approved; Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/tests/channels/pjsip/subscriptions/mwi/mwi_aggregate/mwi_check.py b/tests/channels/pjsip/subscriptions/mwi/mwi_aggregate/mwi_check.py
index fbd4a0a..3cc3261 100644
--- a/tests/channels/pjsip/subscriptions/mwi/mwi_aggregate/mwi_check.py
+++ b/tests/channels/pjsip/subscriptions/mwi/mwi_aggregate/mwi_check.py
@@ -38,11 +38,11 @@
         if not waiting in body:
             LOGGER.error("Could not find pattern %s in MWI body %s" %
                          (waiting, body))
-            controller.fail_test()
+            self.controller.fail_test()
         if not msgs in body:
             LOGGER.error("Could not find pattern %s in MWI body %s" %
                          (msgs, body))
-            controller.fail_test()
+            self.controller.fail_test()
             self.test_object.set_passed(False)
             self.test_object.stop_reactor()
 

-- 
To view, visit https://gerrit.asterisk.org/516
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If536cc76052c0e68e4e5b97384bec2838295c35b
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list