[Asterisk-code-review] res pjsip: Add AMI events for chan pjsip contact lifecycle c... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: Add AMI events for chan_pjsip contact lifecycle changes
......................................................................


Patch Set 4:

> I'll do a separate review to change the testsuite tests to use
 > these AMI events instead of TestEvents, and another to remove the
 > generation of the TestEvents.

Er, no I won't.  The TestEvents provide information that can't be easily replicated (expiration) where the new events are generated and the new events can't be generated where the TestEvents are generated because there's no access to the endpoint stasis infrastructure.

-- 
To view, visit https://gerrit.asterisk.org/510
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d3e288f89bc55e9adbaa7b2c9f9feed4701e2e7
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: No