[Asterisk-code-review] res sorcery memory cache: Add support for object lifetime ma... (asterisk[master])

Mark Michelson asteriskteam at digium.com
Thu May 21 13:23:05 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: res_sorcery_memory_cache: Add support for object_lifetime_maximum.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/499/1/res/res_sorcery_memory_cache.c
File res/res_sorcery_memory_cache.c:

Line 833: *!
        :  * \internal
        :  * \brief Callback function for matching all cached objects
        :  */
        : static int match_object(void *obj, void *arg, int flags)
        : {
        : 	return CMP_MATCH;
        : }
This is unnecessary. Calling ao2_callback with a NULL callback parameter results in all items matching.


-- 
To view, visit https://gerrit.asterisk.org/499
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87409674674a508e7717ee20739ca15cec6ba7b6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list