[Asterisk-code-review] chan sip/sdp crypto.c: allow SDP crypto tag to be up to 9 di... (asterisk[11])
Jared K. Smith
asteriskteam at digium.com
Wed May 20 16:16:21 CDT 2015
Jared K. Smith has posted comments on this change.
Change subject: chan_sip/sdp_crypto.c: allow SDP crypto tag to be up to 9 digits
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Change looks straighforward to me -- my only question is in regards to Richard's question about the Change-ID in the commit message.
https://gerrit.asterisk.org/#/c/497/1//COMMIT_MSG
Commit Message:
Line 13: Change-Id: I58e0788b7ba13e853cfc193fe8d3468f1b588329
> The change id should be the same as the others for proper association.
Is that the case when changes can't be cherry-picked from one branch to another?
--
To view, visit https://gerrit.asterisk.org/497
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e0788b7ba13e853cfc193fe8d3468f1b588329
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Corey Edwards <tensai at zmonkey.org>
Gerrit-Reviewer: Jared K. Smith <jaredsmith at jaredsmith.net>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list