[Asterisk-code-review] Work around thread safety issues in the PBX core. (asterisk[11])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Work around thread safety issues in the PBX core.
......................................................................


Patch Set 1:

> Since this is the PBX core and this changes some fundamental usage
 > of it across the tree I'm not sure I'm comfortable with this going
 > into 11. It may not be correct there, but I can't think of any
 > issues filed as a result of it. We also don't have tests that cover
 > the areas impacted. I'll let others join in on their thoughts.

Are you concerned about:
1) Creation of the nolock variants or changes made to existing functions to allow this?
    or
2) The mass code update to stop using the unsafe variants of the functions?

If it's #1 then I'd like to wait for more opinions.  If it's #2 I can reduce amount of changes, but ultimately I believe they are all correct fixes to race conditions that do exist in code.  I don't think we can confidently say that this hasn't been experienced and reported, just that it hasn't been successfully triaged.  Race conditions can be very difficult to trace.

-- 
To view, visit https://gerrit.asterisk.org/481
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1866b6787730c9c4f3f836b6133ffe9c820734fa
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No