[Asterisk-code-review] res pjsip outbound registration: Check request URI for line. (asterisk[master])

[Matt Jordan]

Matt Jordan has uploaded a new change for review.

  https://gerrit.asterisk.org/495

Change subject: res_pjsip_outbound_registration: Check request URI for line.
......................................................................

res_pjsip_outbound_registration: Check request URI for line.

When an inbound call is received the To header is checked
for the "line" option. Some remote servers will place this
in the request URI instead. This adds an additional check for
the option in the request URI.

ASTERISK-25072 #close
Reported by: Dmitriy Serov

Change-Id: Id4e44debbb80baad623b914a88574371575353c8
---
M res/res_pjsip_outbound_registration.c
1 file changed, 19 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/95/495/1

diff --git a/res/res_pjsip_outbound_registration.c b/res/res_pjsip_outbound_registration.c
index a43fca2..b4970b9 100644
--- a/res/res_pjsip_outbound_registration.c
+++ b/res/res_pjsip_outbound_registration.c
@@ -383,24 +383,29 @@
 	return !pj_strcmp2(&line->value, state->client_state->line) ? CMP_MATCH | CMP_STOP : 0;
 }
 
+static struct pjsip_param *get_uri_option_line(const void *uri)
+{
+        pjsip_sip_uri *pjuri;
+        static const pj_str_t LINE_STR = { "line", 4 };
+
+        if (!PJSIP_URI_SCHEME_IS_SIP(uri) && !PJSIP_URI_SCHEME_IS_SIPS(uri)) {
+                return NULL;
+        }
+        pjuri = pjsip_uri_get_uri(uri);
+        return pjsip_param_find(&pjuri->other_param, &LINE_STR);
+}
+
 /*! \brief Endpoint identifier which uses the 'line' parameter to establish a relationship to an outgoing registration */
 static struct ast_sip_endpoint *line_identify(pjsip_rx_data *rdata)
 {
-	pjsip_sip_uri *uri;
-	static const pj_str_t LINE_STR = { "line", 4 };
-	pjsip_param *line;
-	RAII_VAR(struct ao2_container *, states, NULL, ao2_cleanup);
-	RAII_VAR(struct sip_outbound_registration_state *, state, NULL, ao2_cleanup);
+        pjsip_param *line;
+        RAII_VAR(struct ao2_container *, states, NULL, ao2_cleanup);
+        RAII_VAR(struct sip_outbound_registration_state *, state, NULL, ao2_cleanup);
 
-	if (!PJSIP_URI_SCHEME_IS_SIP(rdata->msg_info.to->uri) && !PJSIP_URI_SCHEME_IS_SIPS(rdata->msg_info.to->uri)) {
-		return NULL;
-	}
-	uri = pjsip_uri_get_uri(rdata->msg_info.to->uri);
-
-	line = pjsip_param_find(&uri->other_param, &LINE_STR);
-	if (!line) {
-		return NULL;
-	}
+        if (!(line = get_uri_option_line(rdata->msg_info.to->uri)) &&
+		!(line = get_uri_option_line(rdata->msg_info.msg->line.req.uri))) {
+                return NULL;
+        }
 
 	states = ao2_global_obj_ref(current_states);
 	if (!states) {

-- 
To view, visit https://gerrit.asterisk.org/495
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4e44debbb80baad623b914a88574371575353c8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Dmitriy Serov <serov.d.p at gmail.com>