[Asterisk-code-review] audiohook.c: Difference in read/write rates caused continuou... (asterisk[11])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: audiohook.c: Difference in read/write rates caused continuous buffer resets
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/#/c/462/5/main/audiohook.c
File main/audiohook.c:

Line 438: 	audiohook_list->list_internal_samp_rate = DEFAULT_INTERNAL_RATE;
> The list's internal rate is set to the highest rate among formats and hooks
Couldn't you invoke audiohook_check_rate to get the new sample rate?


Line 889: 	audiohook_list_check_rate(audiohook_list, frame);
> I don't quite understand all of what you mean. What would the new sample ra
Yeah, I meant determining the new rate as it loops through the audiohooks and uses them - then at the end apply the new sample rate. It's pretty much either: We loop multiple times at the start to determine the sample rate, or we use the old sample rate this one iteration and go for the next one. I personally opt for reducing looping.


-- 
To view, visit https://gerrit.asterisk.org/462
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idab4dfef068a7922c09cc631dda27bc920a6c76f
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes