[Asterisk-code-review] audiohook.c: Difference in read/write rates caused continuou... (asterisk[11])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: audiohook.c: Difference in read/write rates caused continuous buffer resets
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/462/5/main/audiohook.c
File main/audiohook.c:

Line 48: #define DEFAULT_INTERNAL_RATE 8000
Pedantic: #define DEFAULT_INTERNAL_SAMPLE_RATE

It's longer but is more specific.


Line 438: 	audiohook_list->list_internal_samp_rate = DEFAULT_INTERNAL_RATE;
Why can't we operate at the current rate on the list until calculated otherwise?


Line 889: 	audiohook_list_check_rate(audiohook_list, frame);
Hrm - instead of updating the sample rate at the start (which requires us to go through each list for a second time) can a new sample rate be stored at the start, each audiohook updating it (if a higher one is applicable), and then stuff updated at the end?


-- 
To view, visit https://gerrit.asterisk.org/462
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idab4dfef068a7922c09cc631dda27bc920a6c76f
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes