[Asterisk-code-review] cel, cdr: Assigned separator for column name and values. (asterisk[master])

Rodrigo Ramirez Norambuena asteriskteam at digium.com
Wed May 20 10:47:27 CDT 2015


Hello Richard Mudgett, Ashley Sanders,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/469

to look at the new patch set (#4).

Change subject: cel, cdr: Assigned separator for column name and values.
......................................................................

cel, cdr: Assigned separator for column name and values.

Use a separator string between column names and values for SQL sentences
instead of evaluating the separator to use each time.

This change adds a space after the comma in constructing SQL sentences.
Before the SQL was created like "INSERT INTO cdr(calldate,clid,dst"
without spaces between column name and values.

The files applied this change are cdr/cdr_adaptive_odbc.c, cdr/cdr_pgsql.c,
cel/cel_odbc.c

ASTERISK-25109 #close
Reported By: Rodrigo Ramírez Norambuena <decipher.hk at gmail.com>

Change-Id: Ia5a1a161f5e26e1643703b30f8cc9cf0860cc7ea
---
M cdr/cdr_adaptive_odbc.c
M cdr/cdr_pgsql.c
M cel/cel_odbc.c
3 files changed, 66 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/69/469/4
-- 
To view, visit https://gerrit.asterisk.org/469
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5a1a161f5e26e1643703b30f8cc9cf0860cc7ea
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>



More information about the asterisk-code-review mailing list