[Asterisk-code-review] res rtp asterisk.c: don't call dtls perform handshake while ... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: res_rtp_asterisk.c: don't call dtls_perform_handshake while passive
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/490/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 1632: 		if (rtp->rtcp) {
         : 			dtls_perform_handshake(instance, &rtp->rtcp->dtls, 1);
         : 		}
Seems like this should not be within the check for rtp->dtls.dtls_setup.  It should only run with an acceptable rtp->rtcp->dtls.dtls_setup value.


-- 
To view, visit https://gerrit.asterisk.org/490
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I156bd07323eb8c7f99f59fcfe560ce9c3ae60e36
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes