[Asterisk-code-review] res/ari: Register Stasis application on WebSocket attempt (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res/ari: Register Stasis application on WebSocket attempt
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/486/2/res/ari/resource_events.c
File res/ari/resource_events.c:

Line 195: 		res |= stasis_app_register(args->app[i], app_handler, NULL);
If only a single application fails to register and all other applications do this will cause a full failure of this function, what happens to the other registered applications?


https://gerrit.asterisk.org/#/c/486/2/res/stasis/app.c
File res/stasis/app.c:

Line 874: 	if (data) {
You can actually juse do app->data = ao2_bump(data); here


-- 
To view, visit https://gerrit.asterisk.org/486
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dc60dc2b6bee76cd5aff0f69dd53b36e83f636
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes