[Asterisk-code-review] res pjsip outbound registration: Check request URI for line. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_outbound_registration: Check request URI for line.
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/482/4/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 405:         if (!(line = get_uri_option_line(rdata->msg_info.to->uri)) 
You've introduced whitespace at the end.


Line 407:         {
This is also not how our formatting is. { should go at the end of the above.

A nicer way to write it all would be:

if (!(line = get_uri_option_line(rdata->msg_info.to->uri)) &&
!(line = get_uri_option_line(rdata->msg_info.msg->line.req.uri))) {


-- 
To view, visit https://gerrit.asterisk.org/482
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4e44debbb80baad623b914a88574371575353c8
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Dmitriy Serov <serov.d.p at gmail.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rusty Newton <rnewton at digium.com>
Gerrit-HasComments: Yes