[Asterisk-code-review] chan iax2: Prevent deadlock between hangup and sending lagrq... (asterisk[master])

[Y Ateya]

Y Ateya has posted comments on this change.

Change subject: chan_iax2: Prevent deadlock between hangup and sending lagrq/ping
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.asterisk.org/#/c/169/11/channels/chan_iax2.c
File channels/chan_iax2.c:

Line 2076: 	if (ast_sched_find_data(sched, sched_id)) {
> There is a comment in create_callno_pools() that says callno 0 and 1 are re
you are right.

But I think that callno+1 is kind of a hack, and only used to delete from scheduler. So I added API to scheduler to del if id exists and used it instead of find_data then delete. May be this is a little bit cleaner.


Line 2119: AST_SCHED_DEL(sched, pvt->autoid);
         : 	AST_SCHED_DEL(sched, pvt->authid);
         : 	AST_SCHED_DEL(sched, pvt->initid);
         : 	AST_SCHED_DEL(sched, pvt->jbid);
         : 	AST_SCHED_DEL(sched, pvt->keyrotateid);
> Probably should.  You need to be aware that iax2_sched_replace() is going t
ok, I will create separate issue for them.


-- 
To view, visit https://gerrit.asterisk.org/169
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03bec1fc8faacb89630269e935fa667c6d6c080c
Gerrit-PatchSet: 11
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Y Ateya <y.ateya at starkbits.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Y Ateya <y.ateya at starkbits.com>
Gerrit-HasComments: Yes