[Asterisk-code-review] res sorcery memory cache: Add basic module implementation. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_sorcery_memory_cache: Add basic module implementation.
......................................................................


Patch Set 2:

(1 comment)

Aside from a nitpick this looks good.

https://gerrit.asterisk.org/#/c/480/2/res/res_sorcery_memory_cache.c
File res/res_sorcery_memory_cache.c:

Line 1055: 		threadpool_options, "50", OPT_INT_T, PARSE_IN_RANGE,
I'd suggest a lower threadpool maximum size than this. Something like 10 should be sufficient.


-- 
To view, visit https://gerrit.asterisk.org/480
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8a6a357ef5a83d466f81eee56a67d13eeb118b9
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes