[Asterisk-code-review] res pjsip outbound registration: Check request URI for line. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue May 19 14:57:52 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_outbound_registration: Check request URI for line.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/482/3/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 405:         if (!(line = get_uri_option_line(rdata->msg_info.to->uri)) && !(line = get_uri_option_line(rdata->msg_info.msg->line.req.uri)))
Guidelines: Lines longer than 90 need to be continued on the next line.

Please wrap the long line at the &&:
if (!(line = xxx)
   && !(line = yyy)) {
}


-- 
To view, visit https://gerrit.asterisk.org/482
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4e44debbb80baad623b914a88574371575353c8
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Dmitriy Serov <serov.d.p at gmail.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rusty Newton <rnewton at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list