[Asterisk-code-review] res/res config pgsql.c: Use PQescapeStringConn for escaping ... (asterisk[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: res/res_config_pgsql.c: Use PQescapeStringConn for escaping names.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/472/1//COMMIT_MSG
Commit Message:

Line 13
> This change dont have a issue. Is a similar change of c61b1462389be5a2e7fd2
Yes, I believe that an issue should be created. Here are a couple of reasons why:

- The release scripts examine the Asterisk git tree for changes that have associated issues and publishes those as part of the changes list. In order for end-users to be aware of the delta between releases, an issue to map to the commit is required.

- Having issues makes it easier for us developers to trace commits to a requirement and also provides substantiation for the change. In the event that something catastrophic fails (or maybe it was just the build that failed), having this level of traceability is essential for the us to be able to expeditiously diagnose and correct the problem.


-- 
To view, visit https://gerrit.asterisk.org/472
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I302a263f7210d20925f14716b508b081998b7608
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes