[Asterisk-code-review] ASTERISK-25072.res pjsip outbound registration:Additional ch... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: ASTERISK-25072.res_pjsip_outbound_registration:Additional check the request URI
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/482/1//COMMIT_MSG
Commit Message:

Line 7: ASTERISK-25072.res_pjsip_outbound_registration:Additional check the request URI
Please follow the format at https://wiki.asterisk.org/wiki/display/AST/Commit+Messages for commit messages.


https://gerrit.asterisk.org/#/c/482/1/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 386: static struct pjsip_param *get_uri_option_line(const void *uri)
This function doesn't appear to ever be called.


Line 404: 
You've removed the code which looked at the To header URI, and there is no code to look at the Request URI.


-- 
To view, visit https://gerrit.asterisk.org/482
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4e44debbb80baad623b914a88574371575353c8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Dmitriy Serov <serov.d.p at gmail.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rusty Newton <rnewton at digium.com>
Gerrit-HasComments: Yes