[Asterisk-code-review] cdr/cdr csv.c: Set file name for csv master to the module wh... (asterisk[master])
Ashley Sanders
asteriskteam at digium.com
Fri May 15 20:03:53 CDT 2015
Ashley Sanders has posted comments on this change.
Change subject: cdr/cdr_csv.c: Set file name for csv master to the module when (re)loaded.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Please reformat the commit message to follow the Asterisk commit message formatting conventions.
See: https://wiki.asterisk.org/wiki/display/AST/Commit+Messages
https://gerrit.asterisk.org/#/c/404/1//COMMIT_MSG
Commit Message:
Line 12: Change-Id: I3ed9f6a8f965308099db70b71128f43d4d3f5585
Above the Change-Id line, you need to reference the Asterisk issue that this patch is resolving and have a Reported By tag, like:
Asterisk-foo1234 #close
Reported By: Foo Bar
Where:
foo1234 => would be the asterisk issue id
Foo Bar=> would be the name of the person who reported the issue
Please see: https://wiki.asterisk.org/wiki/display/AST/Commit+Messages
--
To view, visit https://gerrit.asterisk.org/404
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ed9f6a8f965308099db70b71128f43d4d3f5585
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list