[Asterisk-code-review] cel, cdr: Assigned separator for column name and values. (asterisk[master])

Ashley Sanders asteriskteam at digium.com
Fri May 15 20:01:49 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: cel, cdr: Assigned separator for column name and values.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Please reformat the commit message to follow the Asterisk commit message formatting conventions.

See: https://wiki.asterisk.org/wiki/display/AST/Commit+Messages

https://gerrit.asterisk.org/#/c/469/3//COMMIT_MSG
Commit Message:

Line 19: Change-Id: Ia5a1a161f5e26e1643703b30f8cc9cf0860cc7ea
Above the Change-Id line, you need to reference the Asterisk issue that this patch is resolving and have a Reported By tag, like:

Asterisk-foo1234 #close
Reported By: Foo Bar

Where:

    foo1234 => would be the asterisk issue id
    Foo Bar=> would be the name of the person who reported the issue

Please see: https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


-- 
To view, visit https://gerrit.asterisk.org/469
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5a1a161f5e26e1643703b30f8cc9cf0860cc7ea
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list