[Asterisk-code-review] res pjsip config wizard/config: Fix template processing (asterisk[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: res_pjsip_config_wizard/config: Fix template processing
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

A few minor issues with the docstrings and commit message.

https://gerrit.asterisk.org/#/c/474/1//COMMIT_MSG
Commit Message:

Line 20: 
You need to add:
Reported By: George Joseph


https://gerrit.asterisk.org/#/c/474/1/include/asterisk/config.h
File include/asterisk/config.h:

Line 340:  * \param list variable list to search
I think this should read:

 * \param list The ast_variable list to search.


Line 341:  * \param variable which variable you wish to get the data for
I think this should read:

 * \param variable The name of the ast_variable you wish to fetch data for.


Line 344:  * Goes through a given variable list and searches for the given variable.
I think this should read:

 * Iterates over a given ast_variable list to search for the last occurrence of an ast_variable element with a name attribute matching the given name (variable).

This is useful if the list has duplicate elements (such as in cases where elements are created by a template).


https://gerrit.asterisk.org/#/c/474/1/res/res_pjsip_config_wizard.c
File res/res_pjsip_config_wizard.c:

Line 337: /*! \brief Finds a variable in a list and tests it */
This should read:
/*! \brief Finds the last variable in a list and tests it */


-- 
To view, visit https://gerrit.asterisk.org/474
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7ddefc956a463923ee6839dd1ebe021c299de4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes