[Asterisk-code-review] cdr/cdr adaptive odbc.c: Assigned separator for column name ... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: cdr/cdr_adaptive_odbc.c: Assigned separator for column name and values.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/469/1//COMMIT_MSG
Commit Message:

Line 9: et a directly separator for column names and values for SQL sentences
      : instead of evaluate in appending if set comma or null separator in sql
      : buffer.
Change to:
Use a separator string between column names and values for SQL sentences instead of evaluating the separator to use each time.


Line 13: This change added one space after comma in construction SQL sentences,
...change adds a space after the comma in constructing SQL sentences.  Before...


https://gerrit.asterisk.org/#/c/469/1/cdr/cdr_adaptive_odbc.c
File cdr/cdr_adaptive_odbc.c:

Line 398: 	char *SEP;
Please rename to "separator".  All uppercase names are used for macros and enum constants.


-- 
To view, visit https://gerrit.asterisk.org/469
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5a1a161f5e26e1643703b30f8cc9cf0860cc7ea
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes