[Asterisk-code-review] Add X.509 subject alternative name support to TLS certificat... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Add X.509 subject alternative name support to TLS certificate verification.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/416/2//COMMIT_MSG
Commit Message:

Line 15: ASTERISK-25063
Append #close to the end of this line since this patch closes the issue.

ASTERISK-25063 #close


https://gerrit.asterisk.org/#/c/416/2/main/tcptls.c
File main/tcptls.c:

Line 669: 
Remove this blank line.  You are setting alt_name to test it.


Line 671: 							int alt_names_count = sk_GENERAL_NAME_num(alt_names);
        : 							for (pos = 0; pos < alt_names_count; pos++) {
Put a blank line between variable declarations and code.

There is a lot of common code in this for loop and the for loop above.  Seems like a good time to refactor the loop bodies into a common function.


-- 
To view, visit https://gerrit.asterisk.org/416
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13302c80490a0b44c43f1b45376c9bd7b15a538f
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Maciej Szmigiero <mail at maciej.szmigiero.name>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes