[Asterisk-code-review] audiohook.c: Difference in read/write rates caused continuou... (asterisk[11])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: audiohook.c: Difference in read/write rates caused continuous buffer resets
......................................................................


Patch Set 2:

It jives for the most part. I agree I should not have removed the audiohook_set_internal_rate calls for whisper and manipulate. However, to me it looks like (in write_list) audiohook_list's internal_samp_rate determines the individual audiohook's internal_samp_rate. Basically, when writing, whatever the audiohook_list's internal_samp_rate is that gets set for each audiohook for all types. What was happening was for the spy list a read could change the internal sample rate. To me the question was, when that occurred, should that affect the audiohook_list's internal sample rate, which in turn affects all audiohooks?

I answered yes, but maybe it should not. Is that what you are saying? It should only affect the spy list?

-- 
To view, visit https://gerrit.asterisk.org/462
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idab4dfef068a7922c09cc631dda27bc920a6c76f
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No