[Asterisk-code-review] cdr adaptive odbc: Add ability to set character for quoted i... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: cdr_adaptive_odbc: Add ability to set character for quoted identifiers.
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.asterisk.org/#/c/246/10/cdr/cdr_adaptive_odbc.c
File cdr/cdr_adaptive_odbc.c:

Line 196: 		tableptr->quoted_identifiers = quoted_identifiers;
> I would probably group this statement with the other tableptr statements ab
It's common practice to use the ordering within the struct for initialization ordering, as was done here. I'm merging it in anyway.


-- 
To view, visit https://gerrit.asterisk.org/246
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9a56b79ca13a727a803d88ed3b8643e37632b8
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes