[Asterisk-code-review] main/manager.c: Bugfix sort action manager by alphabetically (asterisk[13])

Joshua Colp asteriskteam at digium.com
Thu May 14 05:02:51 CDT 2015


Joshua Colp has submitted this change and it was merged.

Change subject: main/manager.c: Bugfix sort action_manager by alphabetically
......................................................................


main/manager.c: Bugfix sort action_manager by alphabetically

Fix the alphabetic order added on ast_manager_register_struct. The order
for struct manager_action added is not working, this change fixes the
problem.

Change-Id: I149da0cd06c3c4445d7516cc303358e9f26f8b4b
---
M main/manager.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified
  Jonathan Rose: Looks good to me, but someone else must approve
  Corey Farrell: Looks good to me, but someone else must approve



diff --git a/main/manager.c b/main/manager.c
index 9aa8ecf..035115f 100644
--- a/main/manager.c
+++ b/main/manager.c
@@ -6755,9 +6755,9 @@
 			return -1;
 		}
 		if (ret > 0) { /* Insert these alphabetically */
-			prev = cur;
 			break;
 		}
+		prev = cur;
 	}
 
 	ao2_t_ref(act, +1, "action object added to list");

-- 
To view, visit https://gerrit.asterisk.org/459
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I149da0cd06c3c4445d7516cc303358e9f26f8b4b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list