[Asterisk-code-review] chan iax2: Prevent deadlock between hangup and sending lagrq... (asterisk[master])

Ashley Sanders asteriskteam at digium.com
Wed May 13 21:36:50 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: chan_iax2: Prevent deadlock between hangup and sending lagrq/ping
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/169/9//COMMIT_MSG
Commit Message:

Line 12: starts but before it deletes the tasks in the scheduler.  The solution is
"The solution is ..." should be in its own paragraph (with a blank line between the two paragraphs for readability).


Line 15: Also this commit cleans up
       : the procedure of sending LAGRQ and PING.
"Also this commit cleans up the procedure of sending LAGRQ and PING." should be in its own paragraph (with a blank line between the two paragraphs for readability) and should be rewritten as:

"This commit also cleans up the procedure of sending LAGRQ and PING."


-- 
To view, visit https://gerrit.asterisk.org/169
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03bec1fc8faacb89630269e935fa667c6d6c080c
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Y Ateya <y.ateya at starkbits.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Y Ateya <y.ateya at starkbits.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list