[Asterisk-code-review] cel/cel pgsql.c: Use the 'SEP' macro when appending a column... (asterisk[master])

Ashley Sanders asteriskteam at digium.com
Wed May 13 14:37:29 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: cel/cel_pgsql.c: Use the 'SEP' macro when appending a column name
......................................................................


Patch Set 2:

(1 comment)

I just had one very minor issue with the commit message.

https://gerrit.asterisk.org/#/c/460/2//COMMIT_MSG
Commit Message:

Line 9: When appending a column name to the sql buffer the predicate "is not first
The predicate is actually: "if first is non-null, use empty string; else, use comma."


-- 
To view, visit https://gerrit.asterisk.org/460
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b6138b06a48381723108a05ab8752cb8700509
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list