[Asterisk-code-review] app voicemail: fix moving when old messages full (asterisk[13])

Ashley Sanders asteriskteam at digium.com
Wed May 13 14:32:30 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: app_voicemail: fix moving when old messages full
......................................................................


Patch Set 1:

(1 comment)

One minor nitpick with the commit message. Otherwise looks good.

https://gerrit.asterisk.org/#/c/461/1//COMMIT_MSG
Commit Message:

Line 10: gets moved to the Old messages folder. Without this patch, if the old
I think you should do something to denote that the word 'old' does not mean former or previous. 

... gets moved to the [OLD] messages folder. Without this patch, if the [OLD] folder is already at its set limit ...


-- 
To view, visit https://gerrit.asterisk.org/461
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2be440a09f42e2d06d50975c40d1ad7f836ecb3f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list