[Asterisk-code-review] main/manager.c: Bugfix sort action manager by alphabetically (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: main/manager.c: Bugfix sort action_manager by alphabetically
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Once you update please cherry-pick to 11 and 13.

https://gerrit.asterisk.org/#/c/435/2/main/manager.c
File main/manager.c:

Line 6783: 		if (ret < 0) { /* Insert these alphabetically */
         : 			prev = cur;
         : 		}
Your change does fix the bug, but it also causes this function to always iterate the complete list.  Switching the code to the below causes the AST_RWLIST_TRAVERSE to stop when the proper value for 'prev' is found:

 if (ret > 0) {
     break;
 }
 prev = cur;


-- 
To view, visit https://gerrit.asterisk.org/435
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I149da0cd06c3c4445d7516cc303358e9f26f8b4b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes