[Asterisk-code-review] Add support for NOWRAP LIBC MALLOC to astmm.h. (asterisk[master])
Richard Mudgett
asteriskteam at digium.com
Tue May 12 13:24:52 CDT 2015
Richard Mudgett has posted comments on this change.
Change subject: Add support for NOWRAP_LIBC_MALLOC to astmm.h.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
I think a better approach needs to be taken to account for the desire to prevent use of free() and friends and the use of those functions for third party code.
https://gerrit.asterisk.org/#/c/442/1/include/asterisk/astmm.h
File include/asterisk/astmm.h:
Line 69: #ifndef NOWRAP_LIBC_MALLOC
: /* Undefine any macros */
: #undef malloc
: #undef calloc
: #undef realloc
: #undef strdup
: #undef strndup
: #undef asprintf
: #undef vasprintf
: #undef free
:
: #ifdef WRAP_LIBC_MALLOC
This whole patch seems to be trying to undo the earlier change to add WRAP_LIBC_MALLOC.
--
To view, visit https://gerrit.asterisk.org/442
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8afef4bc7f3b93914263ae27d3a5858b69663fc7
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list