[Asterisk-code-review] Allow command-line options to override asterisk.conf. (asterisk[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: Allow command-line options to override asterisk.conf.
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/392/3/CHANGES
File CHANGES:

Line 107:  * Most command-line options are now processed after asterisk.conf.  The
> I don't agree.  Let me explain for each option.
That's a fair point.

I suppose my point of contention really rests with the word "most" in that it could be confusing to anyone reading the documentation.

Perhaps the first couple of sentences could be rephrased to something like:
"Modified processing of command-line options to first parse only what is necessary to read asterisk.conf. Once asterisk.conf is fully loaded, the remaining options are processed."


https://gerrit.asterisk.org/#/c/392/3/UPGRADE.txt
File UPGRADE.txt:

Line 39:  - Most command-line options are now processed after asterisk.conf.  The
> Same response as for CHANGES.
My response for CHANGES applies here as well :)


-- 
To view, visit https://gerrit.asterisk.org/392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1450d45c15b4467274b871914d893ed4f6564cd7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes