[Asterisk-code-review] digium git: Add additional capabilities for manipulating bra... (repotools[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: digium_git: Add additional capabilities for manipulating branches/tags
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/381/3/digium_git.py
File digium_git.py:

Line 223:         Raises an exception if tag_name is not found.
It looks like get_tag no longer raises an exception so this comment can be removed.


Line 245:         origin = self.repo.remotes.origin
        :         if self.show_progress:
        :             progress = GitProgressBar()
        :         origin.push(progress=progress, tags=True)
If show_progress is false then progress is unreferenced in the push call. However, I think these lines can just be replaced by a call to self.push_changes


-- 
To view, visit https://gerrit.asterisk.org/381
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d13af5a8201d349b37f64f9855e45b70309aa95
Gerrit-PatchSet: 3
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes