[Asterisk-code-review] vector: Add REMOVE, ADD SORTED and RESET macros (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: vector:  Add REMOVE, ADD_SORTED and RESET macros
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.asterisk.org/#/c/421/7/tests/test_vector.c
File tests/test_vector.c:

Line 209: 	ast_test_validate_cleanup(test, AST_VECTOR_ADD_SORTED(&sv1, ZZZ, strcmp) == 0, rc, cleanup);
        : 	ast_test_validate_cleanup(test, AST_VECTOR_ADD_SORTED(&sv1, BBB, strcmp) == 0, rc, cleanup);
Swapping these two lines will exercise adding a new element onto the end of a non-empty list.

Thus:
Adding BBB first exercises adding to an empty list.
Adding ZZZ exercises adding to the end of a non-empty list.
Adding CCC exercises adding to the middle of the list.
Adding AAA exercises adding to the beginning of a non-empty list.
Adding CCC2 exercises adding a duplicate after existing equal member.


-- 
To view, visit https://gerrit.asterisk.org/421
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41d32dbdf7137e0557134efeff9f9f1064b58d14
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Y Ateya <y.ateya at starkbits.com>
Gerrit-HasComments: Yes