[Asterisk-code-review] sorcery: Add ability to insert a wizard in an object type's ... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: sorcery: Add ability to insert a wizard in an object type's list
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/394/3/main/sorcery.c
File main/sorcery.c:

Line 915: 	return &wizard->wizard->callbacks;
> This only returns the callbacks. It doesn't return the instance data, so yo
Would you rather I...

Expose ast_sorcery_object_wizard and ast_sorcery_internal_wizard and return the ast_sorcery_object_wizard.

or...  create a new public structure with just the wizard and data and return that.

or...  require the caller to pass in **'s to receive the wizard and data

??


-- 
To view, visit https://gerrit.asterisk.org/394
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2469a9296b2698082c0989e25e6848dc403b57
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes