[Asterisk-code-review] chan iax2: Prevent deadlock between hangup and sending lagrq... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: chan_iax2: Prevent deadlock between hangup and sending lagrq/ping
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/169/8/channels/chan_iax2.c
File channels/chan_iax2.c:

Line 1696: 	if (!iaxs[callno] || (iaxs[callno] &&  iaxs[callno]->destroy_initiated)) {
This is not going to even work.  You cannot get access to destroy_initiated without getting the lock and you cannot get the lock because of the deadlock.

The only way I see to resolving this is to fix the double locking of iaxsl[] path when calling iax2_destroy_helper().


-- 
To view, visit https://gerrit.asterisk.org/169
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03bec1fc8faacb89630269e935fa667c6d6c080c
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Y Ateya <y.ateya at starkbits.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Y Ateya <y.ateya at starkbits.com>
Gerrit-HasComments: Yes