[Asterisk-code-review] cdr/cdr adaptive odbc.c: Set character for quoted identifiers. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: cdr/cdr_adaptive_odbc.c: Set character for quoted identifiers.
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/246/7/cdr/cdr_adaptive_odbc.c
File cdr/cdr_adaptive_odbc.c:

Line 159: 			ast_log(LOG_NOTICE, "quoted_identifiers config is must have one character.\n");
This should be an error. It's a configuration error. You should also specify what's going to happen as a result of the configuration error.


-- 
To view, visit https://gerrit.asterisk.org/246
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9a56b79ca13a727a803d88ed3b8643e37632b8
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes